On 23/02/2023 21:20, Alexandre Oliva wrote:
On Feb 23, 2023, Alexandre Oliva <ol...@adacore.com> wrote:
On Feb 23, 2023, Richard Earnshaw <richard.earns...@foss.arm.com> wrote:
On 22/02/2023 19:57, Alexandre Oliva wrote:
On Feb 21, 2023, Richard Earnshaw <richard.earns...@foss.arm.com> wrote:
Rather than scanning for the triplet, a better test would be
{ xfail { arm_eabi } }
Indeed, thanks. Here's the updated patch, retested. Ok to install?
Based on Nathan's comments, we should just skip the test on arm_eabi,
it's simply not applicable.
Like this, I suppose. Retested on x86_64-linux-gnu (trunk) and
arm-wrs-vxworks7 (gcc-12). Ok to install?
Erhm, actually, that version still ran the assembler scans and failed.
This one skips the testset entirely.
Yeah, I tried something like that and it didn't appear to work. Perhaps
it's a bug in the way dg-do-module is implemented.
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
From: Alexandre Oliva <ol...@adacore.com>
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant. ARM is the only target that overrides
TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way
the clash between AAPCS and C++ Modules design should be resolved, but
currently it favors AAPCS and thus the test fails, so skip it on
arm_eabi.
for gcc/testsuite/ChangeLog
PR c++/105224
* g++.dg/modules/virt-2_a.C: Skip on arm_eabi.
---
gcc/testsuite/g++.dg/modules/virt-2_a.C | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C
b/gcc/testsuite/g++.dg/modules/virt-2_a.C
index 580552be5a0d8..ede711c3e83be 100644
--- a/gcc/testsuite/g++.dg/modules/virt-2_a.C
+++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C
@@ -1,3 +1,6 @@
+// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE,
+// in a way that invalidates this test.
+// { dg-skip-if "TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } }
Given the logic of this macro, the text should be
"!TARGET_CXX_METHOD_MAY_BE_INLINE".
OK with that change.
R.
// { dg-module-do run }
// { dg-additional-options -fmodules-ts }
export module foo;
