On Feb 24, 2023, Richard Earnshaw <richard.earns...@foss.arm.com> wrote:
> Given the logic of this macro, the text should be
> "!TARGET_CXX_METHOD_MAY_BE_INLINE".
I was thinking just "related to that macro", but yeah, negating it makes
sense.
> OK with that change.
Thanks, here's what I'm checking in.
[PR105224] C++ modules and AAPCS/ARM EABI clash on inline key methods
From: Alexandre Oliva <ol...@adacore.com>
g++.dg/modules/virt-2_a.C fails on arm-eabi and many other arm targets
that use the AAPCS variant. ARM is the only target that overrides
TARGET_CXX_KEY_METHOD_MAY_BE_INLINE. It's not clear to me which way
the clash between AAPCS and C++ Modules design should be resolved, but
currently it favors AAPCS and thus the test fails, so skip it on
arm_eabi.
for gcc/testsuite/ChangeLog
PR c++/105224
* g++.dg/modules/virt-2_a.C: Skip on arm_eabi.
---
gcc/testsuite/g++.dg/modules/virt-2_a.C | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/testsuite/g++.dg/modules/virt-2_a.C
b/gcc/testsuite/g++.dg/modules/virt-2_a.C
index 580552be5a0d8..b5050445c3f15 100644
--- a/gcc/testsuite/g++.dg/modules/virt-2_a.C
+++ b/gcc/testsuite/g++.dg/modules/virt-2_a.C
@@ -1,3 +1,6 @@
+// AAPCS overrides TARGET_CXX_KEY_METHOD_MAY_BE_INLINE,
+// in a way that invalidates this test.
+// { dg-skip-if "!TARGET_CXX_KEY_METHOD_MAY_BE_INLINE" { arm_eabi } }
// { dg-module-do run }
// { dg-additional-options -fmodules-ts }
export module foo;
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
