On 10/9/23 19:13, juzhe.zh...@rivai.ai wrote:
Oh. I realize this patch increase FAIL that I recently fixed:
https://gcc.gnu.org/pipermail/gcc-patches/2023-October/632247.html <https://gcc.gnu.org/pipermail/gcc-patches/2023-October/632247.html>

This fail because RVV doesn't have vec_pack_trunc_optab (Loop vectorizer will failed at first time but succeed at 2nd time), then RVV will dump 4 times FOLD_EXTRACT_LAST instead of 2  (ARM SVE 2 times because they have vec_pack_trunc_optab).

I think the root cause of RVV failing at multiple tests of "vect" is that we don't enable vec_pack/vec_unpack/... stuff,
we still succeed at vectorizations and we want to enable tests of them
(Mostly just using different approach to vectorize it (cause dump FAIL) because of some changing I have done previously in the middle-end).

So enabling "vec_pack" for RVV will fix some FAILs but increase some other FAILs.

CC to Richi to see more reasonable suggestions.
So what is the summary on Maciej's patch to enable vec_pack_trunc? ie, is it something we should move forward with as-is, is it superceded by your work in this space or does it need further investigation because of differences in testing methodologies or something else?

jeff

Reply via email to