Hello, Andrew. Thank you for your input. I've updated the "fixing" patch according to your feedback. Please let me know if I understood it correctly.
Radek ________________________________ From: Andrew Pinski <pins...@gmail.com> Sent: Thursday, January 4, 2024 8:11 PM To: Radek Barton <radek.bar...@microsoft.com>; Andrew Pinski (QUIC) <quic_apin...@quicinc.com> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org> Subject: [EXTERNAL] Re: Fw: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target? [You don't often get email from pins...@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On Thu, Jan 4, 2024 at 5:51 AM Radek Barton <radek.bar...@microsoft.com> wrote: > > Hello, everyone. > > > Our "Arm64 on Windows Ecosystem" team is currently working on adding > aarch64-w64-mingw32 target and we've noticed that recent commit adding SME > support > (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fpipermail%2Fgcc-cvs%2F2023-December%2F394915.html&data=05%7C02%7Cradek.barton%40microsoft.com%7C51df4d9506014407bc8908dc0d58eeac%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638399922842775482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5%2FK9lrqVSFn35cxjmhyEnKpiArJEMcOp5BQbAr%2F3r1s%3D&reserved=0<https://gcc.gnu.org/pipermail/gcc-cvs/2023-December/394915.html>) > is using .hidden and .size pseudo-ops that are not supported by this target > yet. We'd like to hear your opinion what would be the most acceptable fix for > the community: > > Wrap the unsupported pseudo-ops using macros and #ifdef them for the target. > The attached 0001-Ifdef-.hidden-and-.size-pseudo-ops-for-aarch64-w64-m.patch > is demonstrating this option. > Move SME related sources to a separate config, t-sme, that won't be included > by the aarch64-w64-mingw32 target config. The attached > 0001-Exclude-SME-feature-from-libgcc-for-aarch64-w64-ming.patch by Evgeny > Karpov is a proposal of this change. > Do you have any other proposal? For the .type issue you should use the following define instead: ``` #ifdef __ELF__ #define TYPE(x) .type x,function #else #define TYPE(x) #endif ``` Which comes directly from config/aarch64/crti.S . HIDDEN should be handled similarly. We really should still have SME support for GCC for windows. Thanks, Andrew Pinski > > > Best regards, > > Radek Bartoň
0001-Ifdef-.hidden-.type-and-.size-pseudo-ops-for-aarch64.patch
Description: 0001-Ifdef-.hidden-.type-and-.size-pseudo-ops-for-aarch64.patch
