On Wed, Feb 21, 2024 at 12:48 PM Evgeny Karpov <evgeny.kar...@microsoft.com> wrote: > > Hello, > > We would like to take your attention to the review of changes for the > new GCC target, aarch64-w64-mingw32. The new target will be > supported, tested, added to CI, and maintained by Linaro. This marks > the first of three planned patch series contributing to the GCC C > compiler's support for Windows Arm64. > > 1. Minimal aarch64-w64-mingw32 C implementation to cross-compile > hello-world with libgcc for Windows Arm64 using MinGW. > 2. Extension of the aarch64-w64-mingw32 C implementation to > cross-compile OpenSSL, OpenBLAS, FFmpeg, and libjpeg-turbo. All > packages successfully pass tests. > 3. Addition of call stack support for debugging, resolution of > optimization issues in the C compiler, and DLL export/import for the > aarch64-w64-mingw32 target. > > This patch series introduces the 1st point, which involves building > hello-world for the aarch64-w64-mingw32 target. The patch depends on > the binutils changes for the aarch64-w64-mingw32 target that have > already been merged. > > The binutils should include recent relocation fixes. > f87eaf8ff3995a5888c6dc4996a20c770e6bcd36 > aarch64: Add new relocations and limit COFF AArch64 relocation offsets > > The series is structured in a way to trivially show that it should not > affect any other targets.
To be clear, because of the refactoring, it will affect x86/x64 Windows targets. Can you do a testsuite run before and after and see that it doesn't get worse? The full testsuite for all languages for Windows isn't in great shape, but it's not awful. Some languages, like Rust and Fortran, have ~10 FAILs. C and C++ have several thousand. In particular, there are quite a few testsuite test FAILs regarding MS ABI that hopefully do not get worse. Lastly, I don't think I see in the current patch series where you add new testsuite coverage for aarch64-specific bits. I probably missed it, so feel free to helpfully correct me there :) I'd be curious to see how the tests were written to take into account target differences (using for example the dejagnu feature procs) and other nuances.
