On Thu, Feb 29, 2024 at 11:26 AM Evgeny Karpov <evgeny.kar...@microsoft.com> wrote: > > Monday, February 26, 2024 2:30 AM > NightStrike wrote: > > > To be clear, because of the refactoring, it will affect x86/x64 Windows > > targets. > > Can you do a testsuite run before and after and see that it doesn't get > > worse? > > The full testsuite for all languages for Windows isn't in great shape, but > > it's not > > awful. Some languages, like Rust and Fortran, have ~10 FAILs. C and C++ > > have > > several thousand. > > > > In particular, there are quite a few testsuite test FAILs regarding MS ABI > > that > > hopefully do not get worse. > > > > Thank you for bringing it up! Our CI will be extended to test the x64 > mingw target and calculate a delta, starting from patch series v2.
Thanks. You should probably include x86 also, at least for all the areas that overlap. I would like to compare my own test results with yours when you have that ready. You can send test results to the gcc mailing list setup for this purpose: https://gcc.gnu.org/mailman/listinfo/gcc-testresults, and there are scripts in contrib/ to help automate the process. I personally stopped, because the clusters I used had their mail sending capabilities cut off, but I'm working on fixing that. > > Lastly, I don't think I see in the current patch series where you add new > > testsuite coverage for aarch64-specific bits. I probably missed it, so > > feel free to > > helpfully correct me there :) I'd be curious to see how the tests were > > written to > > take into account target differences (using for example the dejagnu feature > > procs) and other nuances. > > Tests have not been added yet. This does not mean they do not exist > or are not used. They are implemented and used in our CI, and will be > contributed to the aarch64-w64-mingw32 target in the next patch > series. > https://github.com/Windows-on-ARM-Experiments/mingw-woarm64-build/tree/main/tests Awesome! These tests look like they are handled by your own custom test harness, so hopefully it won't be too difficult to convert it all to dejagnu. Honestly, the sooner you do that, the better, because the task is going to balloon. You'll find that Deja offers all kinds of neat and useful features that allow you to test all kinds of things, so it'll result in better coverage in the end.
