On 6/12/24 2:50 AM, Kewen.Lin wrote: > As the recent PR115355 shows, this issue can also affect the > behavior when users are adopting vectorization optimization, > IMHO we should get this landed as soon as possible.
I agree we want this fixed ASAP. > As all said above, I believe this patch is a correct fix and > considering the impact of the issue, I'd like to get this > pushed next week if no objections. The only complaint I have on the patch, and I know this existed before the patch, is we're using register_operand for the predicate for these patterns when we probably should be using altivec_register_operand or vsx_register_operand depending on the specific pattern. Yes, other pre-existing patterns use that, but those should probably be fixed too. Maybe we go with register_operand for now with this patch and then have a follow-on patch (from us) that cleans those all up??? Otherwise, LGTM (although I can't approve it). Peter
