on 2024/6/19 03:02, Peter Bergner wrote: > On 6/12/24 2:50 AM, Kewen.Lin wrote: >> As the recent PR115355 shows, this issue can also affect the >> behavior when users are adopting vectorization optimization, >> IMHO we should get this landed as soon as possible. > > I agree we want this fixed ASAP. > > > > >> As all said above, I believe this patch is a correct fix and >> considering the impact of the issue, I'd like to get this >> pushed next week if no objections. > > The only complaint I have on the patch, and I know this existed before > the patch, is we're using register_operand for the predicate for these > patterns when we probably should be using altivec_register_operand or > vsx_register_operand depending on the specific pattern.
Good catch. > > Yes, other pre-existing patterns use that, but those should probably be > fixed too. Maybe we go with register_operand for now with this patch > and then have a follow-on patch (from us) that cleans those all up??? Yes, since this issue existed before and sort of widely, I think we want some other separated patch to clean them up. > > Otherwise, LGTM (although I can't approve it). Thanks! I noticed Segher posted some more review comments on patch v4, I'll follow up them. :) BR, Kewen
