Am 30.08.24 um 18:33 schrieb Steve Kargl:
On Thu, Aug 29, 2024 at 10:05:35PM +0200, Harald Anlauf wrote:
Am 29.08.24 um 21:53 schrieb Steve Kargl:
Thanks for the patch. If you have not already opened a new PR for the
other issue with C8107, I'll open one later today. It's likely that
we need to check the namelist-group-name for USE association in
match.cc:gfc_match_namelist.
Hmmm, it seems we already catch the error, but accept it as an
extension.
% gfcx -o z -std=f2023 a.f90 && ./z
a.f90:11:23:
11 | namelist /nam_nml1/j
| 1
Error: GNU Extension: Namelist group name 'nam_nml1' at (1) already
is USE associated and cannot be respecified.
ah, I overlooked this.
In hindsight, I wish GNU extensions had warnings associated with them.
Should we downgrade this extension to GFC_STD_LEGACY?
I would support such a downgrade. In fact, I would
support making -std=f2023 the default, but that might
be pushing my luck.
Making -std=f2023 the default would likely generate testsuite
fallout. Before considering that seriously, it would make sense to
audit the testsuite for poorly written testcases which inadvertently
use GNU extensions (these should get the appropriate dg-options
if testing the extension was desired). That's something a
volunteer could also contribute.
Not sure when it was implemented or where it was used.
'git blame' shows the code was last touch in 2011.
I suspect that it is much older.
I checked 'git log -p' output and found that the
gfc_notify_std (GFC_STD_GNU, ...) in question exists since 2005.
There was some reformatting later, last in 2011.
Harald
