Hi Robert,
On Thu, Aug 30, 2012 at 6:30 AM, rbmj <[email protected]> wrote:
>> Done, and patch is attached.
>>
>
> OK. make install doesn't seem to like it as much as I do. It complains
> because it tries to install macro_list and can't find it. Proposed
> solutions:
>
> 2. Change line to read test -f ${MACRO_LIST} && rm -f ${MACRO_LIST} && touch
> ${MACRO_LIST}
> Advantages- Will not unnecessarily run machine_name. Saves 4 bytes of disk
> usage over option 1 :D
> Disadvantages- Looks rather hackish; something about it feels wrong
Agreed. You would have to add a comment
> 1. Change line to read test -f ${MACRO_LIST} && echo > ${MACRO_LIST}
> Advantages- easy, simple
> Disadvantages- might cause an unnecessary run of the fix. A very, very
> small potential compile time hit.
"GCC compile time hit" Anyway, this looks cleaner and I surely don't see
much difference between this and #2 above.
> 3. Make macro_list optional for installation
> Disadvantages- more complex, and I don't really feel like going back into
> the makefiles again. That's a scary place.
Amen. Keep it as simple as you can. Thanks.
