Hi,

On Mon, Sep 10, 2012 at 10:48 AM, rbmj <r...@verizon.net> wrote:
> On the other hand, I've read this on the website:
>
>> Don't mix together changes made for different reasons. Send them
>> individually.  Ideally, each change you send should be impossible to
>> subdivide into
>
> parts that we might want to consider separately, because each of its parts
> gets its motivation from the other parts

OTOH, this is a fairly cohesive set of patches.
A single project.  Even if, strictly speaking, each include fix
is entirely separate from the others (by the design of fixincludes),
I see them as a cohesive set that ought to be in a single commit.
Fixes to fixes for fixincludes have been very infrequent.

> ... At the same
> time, it's a pain in the rear to worry about 12 different commits

I'm into comforting one's derriere.

> Unless cosmic rays break everything again, that should be all.

:)  OK.  I'll push it on your behalf once the other bits have been
approved by their approvers.

Cheers - Bruce

Reply via email to