Hi Jonathan,
> There doesn't seem to be much benefit to writing the symbols to
> baseline_symbols.txt.new when an existing file is already present. It
> just adds a manual step for maintainers to move the .txt.new file to
> replace the .txt one. Overwriting the file directly allows you to use
> git diff to see what changed immediately, and you can easly use git
> commands to revert to the original file too.
>
> libstdc++-v3/ChangeLog:
>
> * testsuite/Makefile.am (new-abi-baseline): Overwrite existing
> file instead of creating baseline_symbols.txt.new.
> * testsuite/Makefile.in: Regenerate.
> ---
>
> Does anybody prefer the way it works now? I don't, but I'd like to hear
> from target maintainers who do most of the work to update the baseline
> files.
I've one concern, though: sometimes you need to remove some changes from
the regenerated baselines (don't have an examply handy, but am pretty
sure this has happened in the past). If you make updating the baseline
too easy, something like this might be missed more easily :-)
Apart from that, no objections from me.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
