Hi Jonathan,
>> I've one concern, though: sometimes you need to remove some changes from
>> the regenerated baselines (don't have an examply handy, but am pretty
>> sure this has happened in the past). If you make updating the baseline
>> too easy, something like this might be missed more easily :-)
>
> I did consider that, because when I ran it to test the changes, 'git
> diff' showed the TLS symbols that we don't want to commit to the
> x86_64-pc-linux-gnu baseline.
>
> But I'm not sure if it really makes it too easy? I doubt anybody is
> copying individual changes from the .new file to the real one, surely
> they just do 'mv foo.txt.new foo.txt' and then use 'git diff', and in
> that case, they still need to manually remove some changes.
>
> It would only be a problem if people run the make target, then do git
> commit without checking the diff. But they could already do that today
> after mv'ing the file.
I'd hope this would be caught during review, though: I believe that even
baseline updates need to go through patch review first, right?
As I said: it not a serious concern, just something to think about.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
