On Wed, Oct 24, 2012 at 12:52 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >> Please take a look at the attached patch. >> >> I changed the asm-pattern implementation according to your recomendation. >> Changed the name of feature option from -mfxsave to -mfxsr, as it is in >> Intel SDM. Corrected the arguments name in the headers. >> >> Bootstrap passes > > I think you should add bit_FXSR. Also you should turn off XSAVE if OSXSAVE is > off, according to Intel SDM.
There is no need for additional bit_FXSR. We already have plenty of "misnamed" bits in cpuid.h and we can live with them just fine. > I think we should check OSFXSR bit for OS SSE support in driver-i386.c before > enabling SSE and FXSR, similar to OSXSAVE bit. If we do that, we should > enable > FXSR when enabling SSE. This was already discussed, and the conclusion was that SSE and FXSR are orhogonal, so we don't need to tie them together. Uros.
