Re: [PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

[Uros Bizjak]

On Wed, Oct 24, 2012 at 1:06 PM, Uros Bizjak <ubiz...@gmail.com> wrote:
> On Wed, Oct 24, 2012 at 12:52 PM, H.J. Lu <hjl.to...@gmail.com> wrote:
>>> Please take a look at the attached patch.
>>>
>>> I changed the asm-pattern implementation according to your recomendation.
>>> Changed the name of feature option from -mfxsave to -mfxsr, as it is in
>>> Intel SDM. Corrected the arguments name in the headers.
>>>
>>> Bootstrap passes
>>
>> I think you should add bit_FXSR.  Also you should turn off XSAVE if OSXSAVE 
>> is
>> off, according to Intel SDM.

The xsave and xsaveopt bis are switched off in this part:

@@ -481,6 +490,8 @@ const char *host_detect_local_cpu (int argc, const
char **argv)
       has_fma = 0;
       has_fma4 = 0;
       has_xop = 0;
+      has_xsave = 0;
+      has_xsaveopt = 0;
     }

   /* Check cpuid level of extended features.  */

So, the patch is OK for mainline (with -mxsave removed from sse-X tests).

Please commit the patch to mainline SVN.

(BTW: I have a patch that uses fxsave builtin in crtfastmath.c).

Thanks,
Uros.