On 05/24/13 13:43, Iyer, Balaji V wrote:

Hi Jakub,
        I moved all the tests from gcc.dg/cilk-plus/AN directory to 
c-c++-common/cilk-plus/AN directory. The gcc.dg/cilk-plus directory just 
contains cilk-plus.exp script, which will handle all the tests in cilk-plus, 
not just array notation (when the others are checked in that is). Is this what 
you requested?
...
...
        * c-c++-common/cilk-plus/AN/gather_scatter.c: Likewise.
        * c-c++-common/cilk-plus/AN/n-ptr-test.c: Likewise.
        * c-c++-common/cilk-plus/AN/side-effects-1.c: Likewise.
        * c-c++-common/cilk-plus/AN/test_builtin_return.c: Likewise.
        * c-c++-common/cilk-plus/AN/test_sec_limits.c: Likewise.
        * gcc.dg/cilk-plus/cilk-plus.exp: New script.

Yes, I believe that's what Jakub is requesting. Basically, what we want is that common tests that should work on both C and C++ go inside the c-c++-common infrastructure, and thus have one test that stresses both front ends.

However, you may still need some gcc.dg/cilk-plus/* directory with corresponding infrastructure if you have any tests that are exclusive to C (and when you have C++ specific tests, corresponding g++.dg/cilk-plus infrastructure).

I'm curious, since you currently don't have any array notation support for C++, the above patch should give lots of errors when it tries to test the cilkplus tests on C++. Does it not give you errors? For now you may need some conditional to avoid running the tests on C++ until you get the C++ FE changes reviewed and approved.

Aldy

Reply via email to