On 14/06/13 14:55, Vidya Praveen wrote:
Hello,

This patch adds support to SMLAL/SMLSL/UMLAL/UMLSL instructions and adds tests
for the same. Regression test run for aarch64-none-elf with no regressions.

OK?

~VP

---

gcc/ChangeLog

2013-06-14  Vidya Praveen <vidyaprav...@arm.com>

        * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal_lo<mode>):
          New pattern to support SMLAL,UMLAL instructions.
        * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal_hi<mode>):
          New pattern to support SMLAL2,UMLAL2 instructions.
        * config/aarch64/aarch64-simd.md (*aarch64_<su>mlsl_lo<mode>):
          New pattern to support SMLSL,UMLSL instructions.
        * config/aarch64/aarch64-simd.md (*aarch64_<su>mlsl_hi<mode>):
          New pattern to support SMLSL2,UMLSL2 instructions.
        * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal<mode>): New pattern
          to support SMLAL/UMLAL instructions for 64 bit vector modes.
        * config/aarch64/aarch64-simd.md (*aarch64_<su>mlsl<mode>): New pattern
          to support SMLSL/UMLSL instructions for 64 bit vector modes.


Convention is that we say what changed in the changelog entry and write the justification in the covering email summary. Therefore in instances like this where you are defining a new pattern in is sufficient to write simply.

 * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal_lo<mode>): Define.

gcc/testsuite/ChangeLog

2013-06-14  Vidya Praveen <vidyaprav...@arm.com>

        * gcc.target/aarch64/vect_smlal_1.c: New file.


Otherwise this is OK.

You should apply for write access to the tree. Follow the instruction on the WIKI here:

http://gcc.gnu.org/svnwrite.html#authenticated

Cheers
/Marcus


Reply via email to