On 14/06/13 15:33, Marcus Shawcroft wrote:
> On 14/06/13 14:55, Vidya Praveen wrote:
>> Hello,
>>
>> This patch adds support to SMLAL/SMLSL/UMLAL/UMLSL instructions and adds
>> tests
>> for the same. Regression test run for aarch64-none-elf with no regressions.
>>
>> OK?
>>
>> ~VP
>>
>> ---
>>
>> gcc/ChangeLog
>>
>> 2013-06-14 Vidya Praveen <vidyaprav...@arm.com>
>>
>> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal_lo<mode>):
>> New pattern to support SMLAL,UMLAL instructions.
>> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal_hi<mode>):
>> New pattern to support SMLAL2,UMLAL2 instructions.
>> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlsl_lo<mode>):
>> New pattern to support SMLSL,UMLSL instructions.
>> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlsl_hi<mode>):
>> New pattern to support SMLSL2,UMLSL2 instructions.
>> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal<mode>): New pattern
>> to support SMLAL/UMLAL instructions for 64 bit vector modes.
>> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlsl<mode>): New pattern
>> to support SMLSL/UMLSL instructions for 64 bit vector modes.
>
>
> Convention is that we say what changed in the changelog entry and write
> the justification in the covering email summary. Therefore in instances
> like this where you are defining a new pattern in is sufficient to write
> simply.
>
> * config/aarch64/aarch64-simd.md (*aarch64_<su>mlal_lo<mode>): Define.
>
I tend to prefer "New pattern." over "Define." on the grounds that it tells me
that this is a pattern, not a constraint or some other construct.
Also, there's no need to repeat the file name each time, or put the leading '*'
on the pattern name. You can
also list more than one function at the same time if it has the same
description, and use 'Likewise' when this
extends to multiple lines.
Finally, don't over-indent continuation lines.
So:
2013-06-14 Vidya Praveen <vidyaprav...@arm.com>
* config/aarch64/aarch64-simd.md (aarch64_<su>mlal_lo<mode>):
New pattern.
(aarch64_<su>mlal_hi<mode>, aarch64_<su>mlsl_lo<mode>): Likewise.
(aarch64_<su>mlsl_hi<mode>, aarch64_<su>mlal<mode>): Likewise.
etc.
