> > On Mon, Nov 04, 2013 at 12:59:49PM +0100, Bernd Edlinger wrote: >> I see another "read_line" at gcov.c, which seems to be a copy. > > Copy of what? gcov.c read_line hardly can be allowed to fail because out of > mem unlike this one for caret diagnostics. > Though, surely, this one could be somewhat adjusted so that it really > doesn't use a temporary buffer but reads directly into the initially > malloced, then realloced, buffer. But, if we want it to eventually switch > to caching the caret diagnostics, it won't be possible/desirable anymore. > > Jakub
gcov.c and input.c currently both have a static function "read_line" they are currently 100% in sync. Both _can_ fail, if the file gets deleted or modified while the function executes. If gcov.c crashes in that event, I'd call it a bug. Bernd.
