On Fri, Nov 15, 2013 at 10:40 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Fri, Nov 15, 2013 at 10:34:28PM +0400, Konstantin Serebryany wrote: >> +samsonov, who wrote the clang part >> >> Do you plan to add tests? > > Eventually yes, but likely only in stage3, there is only limited time > left during stage1 and I need to still work on OpenMP elementals next week.
sure. > >> We have four lit-style tests for this (Alexey, that's all, right?): >> init-order-atexit.cc >> init-order-dlopen.cc >> init-order-pthread-create.cc >> Linux/initialization-bug-any-order.cc >> >> I think we need at least the basic one in gcc >> (Linux/initialization-bug-any-order.cc) > > What should be done is just diff the compiler-rt tests in between the date > where we mass ported most of the tests last time and now, and just port > (where appropriate) the tests to DejaGNU. It is at most a few hours of > work. That's never like this. Half a year later we'll change something in the run-time and will update tests in compiler-rt accordingly. Then two more months later I'll try to make a merge to gcc and will find that I have to fix the tests there too. At that point I'll be in different context (and, besides, I am not that familiar with dejagnu). That's what I call doubled maintenance cost. The more tests we have in gcc (and we do want to have more tests) the higher is the cost. > > Jakub
