On Fri, Oct 3, 2014 at 4:32 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> Hi!
>
> I've noticed that expand_vec_perm_1 completely uselessly builds GC garbage
> (CONST_VECTOR at least) when AVX512F isn't enabled at all.
>
> Ok to just call it for AVX512F?
OK.
> Even better would be to check the modes first too depending on target
> (AVX512F will only handle V{8D,16S}{I,F}mode, AVX512BW would handle
> also V32HImode (not yet implemented?), AVX512VL could handle
> V{2D,4D,4S,8S}{I,F}mode (not yet implemented?, though is there any
> const permutation not handled yet earlier?), and AVX512VL+AVX512BW
> could handle V{8,16}HImode (not yet implemented?) before creating a
> CONST_VECTOR.
AVX512BW and AVX512VL are currently moving targets, I propose to look
at this issue once all changes are committed to the repository.
> 2014-10-03 Jakub Jelinek <ja...@redhat.com>
>
> * config/i386/i386.c (ix86_expand_vec_perm_vpermi2): Fix up
> formatting.
> (ix86_expand_vec_perm): Only call ix86_expand_vec_perm_vpermi2 if
> TARGET_AVX512F.
> (expand_vec_perm_1): Likewise.
OK.
Thanks,
Uros.
