Hi All, Please suggest if changes are required in the patch.
Thanks, Sangamesh On Fri, Jul 4, 2025 at 11:48 PM swamy sangamesh <swamy.sangam...@gmail.com> wrote: > Tried with the below change and able to bootstrap on AIX and X86. > > diff --git a/gcc/tree.cc b/gcc/tree.cc > index e9a83e4260b..b693a58ab9d 100644 > --- a/gcc/tree.cc > +++ b/gcc/tree.cc > @@ -64,6 +64,7 @@ along with GCC; see the file COPYING3. If not see > #include "stringpool.h" > #include "attribs.h" > #include "rtl.h" > +#include "tm_p.h" > #include "regs.h" > #include "tree-vector-builder.h" > #include "gimple-fold.h" > > Please suggest if this is the right place to add tm_p.h. > > > On Tue, Jul 1, 2025 at 11:04 PM Andrew Pinski <pins...@gmail.com> wrote: > >> On Tue, Jul 1, 2025 at 10:31 AM swamy sangamesh via Gcc <gcc@gcc.gnu.org> >> wrote: >> > >> > Thank you all for your response. >> > >> > I would be posting regression test results regularly and will work on >> > setting up a buildbot for AIX. >> > >> > I can see that currently the AIX build is broken with the below error. >> > >> > In file included from ./tm.h:25, >> > from >> /opt/freeware/src/packages/BUILD/gcc/gcc/backend.h:28, >> > from >> /opt/freeware/src/packages/BUILD/gcc/gcc/tree.cc:33: >> > /opt/freeware/src/packages/BUILD/gcc/gcc/tree.cc: In function >> 'tree_node* >> > generate_internal_label(const char*)': >> > /opt/freeware/src/packages/BUILD/gcc/gcc/config/rs6000/xcoff.h:206:30: >> > error: 'rs6000_xcoff_strip_dollar' was not declared in this scope >> > 206 | sprintf (LABEL, "*%s..%u", rs6000_xcoff_strip_dollar (PREFIX), >> > (unsigned) (NUM)) >> > | ^~~~~~~~~~~~~~~~~~~~~~~~~ >> > /opt/freeware/src/packages/BUILD/gcc/gcc/tree.cc:819:3: note: in >> expansion >> > of macro 'ASM_GENERATE_INTERNAL_LABEL' >> > 819 | ASM_GENERATE_INTERNAL_LABEL (tmp, prefix, num++); >> > >> > This seems to have caused by >> > >> https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=0337e3c2743ca0c57da8c6b78b725a7d83f0b721 >> > >> > Analysing more on this failure. >> >> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120866#c4 explictly . >> >> Thanks, >> Andrew >> >> >> > >> > Thanks, >> > Sangamesh >> > >> > On Mon, Jun 30, 2025 at 8:48 PM David Edelsohn <dje....@gmail.com> >> wrote: >> > >> > > The general criteria for primary, secondary, and tertiary platforms >> are >> > > described on the page to which you linked. >> > > >> > > The choice of level is decided by the GCC Steering Committee in >> > > consultation with the GCC Release Managers and the maintainers for the >> > > targets / platforms. >> > > >> > > AIX is an unusual platform that always has required extra effort from >> the >> > > GCC community. The reduction in participation and investment from IBM >> > > means that the GCC community cannot tie its functional status to the >> > > release criteria for GCC. >> > > >> > > Thanks, David >> > > >> > > On Mon, Jun 30, 2025 at 10:48 AM swamy sangamesh < >> > > swamy.sangam...@gmail.com> wrote: >> > > >> > >> Hi All, >> > >> >> > >> Would like to know the criteria for adding AIX as a secondary >> platform. >> > >> https://gcc.gnu.org/gcc-15/criteria.html >> > >> >> > >> Willing to participate in the work needed for the platform to be >> added as >> > >> primary and secondary. >> > >> >> > >> >> > >> -- >> > >> Thanks & Regards, >> > >> Sangamesh >> > >> >> > > >> > >> > -- >> > Thanks & Regards, >> > Sangamesh >> > > > -- > Thanks & Regards, > Sangamesh > -- Thanks & Regards, Sangamesh
