On Sun, 26 Oct 2025, 01:38 Andrew Pinski via Gcc, <[email protected]> wrote:

> On Sat, Oct 25, 2025 at 3:44 PM Gerald Pfeifer via Overseers
> <[email protected]> wrote:
> >
> > I saw this last month, where there were spaces instead of a tab - so a
> > diagnosis is correct, just the specific error message is off: That line
> > definitely should not start with a tab.
> >
> > Who can help and address that?
>

If that line wasn't the problem, could you tell us what the real error in
the commit msg was? It's a bit hard to try and reproduce it (and then fix
the hook) if we only see a correct line with the report of an unspecified
problem that isn't shown :)


>
> > Gerald
> >
> >
> > remote: *** The following commit was rejected by your
> hooks.commit-extra-checker script (status: 1)
> > remote: *** commit: 7fde41ebe7a61b6b549c160cb3bb8374e6f4730f
> > remote: *** ChangeLog format failed:
> > remote: *** ERR: line should start with a tab: "Signed-off-by:  Jonathan
> Grant <[email protected]>"
> > remote: ***
> > remote: *** Please see:
> https://gcc.gnu.org/codingconventions.html#ChangeLogs
> > remote: *** remote: error: hook declined to update refs/heads/trunk
>
> This error message is coming from
> `contrib/gcc-changelog/git_check_commit.py` (and
> `contrib/gcc-changelog/git_commit.py`) rather than anything overseers
> controls.
>
> Thanks,
> Andrew
>
> >
>

Reply via email to