On Dec 20, 2007, Andrew Haley <[EMAIL PROTECTED]> wrote:
> Alexandre Oliva writes:
>> PR debug/7081
>> * lang.c (java_classify_record): New.
>> (LANG_HOOKS_CLASSIFY_RECORD): Override.
> Yeah, I discovered this today. Because your patch hadn't been flagged
> as affecting Java and no Java maintainer approved it, I hadn't
> noticed.
Sorry.
>> What now, revert until GDB et al are fixed, or leave it in, for
>> it's the right thing to do, and it serves as an additional
>> incentive for debug information consumers to support new Dwarf 3
>> features?
> Please revert it, right now.
How about this patch, instead? It will restore debuggability to Java
while at the same time maintaining the progress of using the
long-supported-by-GDB DW_TAG_class_type in both C++ and Java.
for gcc/java/ChangeLog
from Alexandre Oliva <[EMAIL PROTECTED]>
* lang.c (java_classify_record): Don't return
RECORD_IS_INTERFACE for now.
Index: gcc/java/lang.c
===================================================================
--- gcc/java/lang.c.orig 2007-12-15 18:18:56.000000000 -0200
+++ gcc/java/lang.c 2007-12-20 12:17:26.000000000 -0200
@@ -965,7 +965,9 @@ java_classify_record (tree type)
if (! CLASS_P (type))
return RECORD_IS_STRUCT;
- if (CLASS_INTERFACE (TYPE_NAME (type)))
+ /* ??? GDB does not support DW_TAG_interface_type as of December,
+ 2007. Re-enable this at a later time. */
+ if (0 && CLASS_INTERFACE (TYPE_NAME (type)))
return RECORD_IS_INTERFACE;
return RECORD_IS_CLASS;
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member http://www.fsfla.org/
Red Hat Compiler Engineer [EMAIL PROTECTED], gcc.gnu.org}
Free Software Evangelist [EMAIL PROTECTED], gnu.org}
