On Sun, Jan 10, 2010 at 10:36 PM, Andrew Hutchinson
<andrewhutchin...@cox.net> wrote:
>
>
> Kai Tietz wrote:
>>
>> Well, open call there aren't that much but point of interest is in
>> 'c-pch.c:  fd = open (name, O_RDONLY | O_BINARY, 0666);' as it uses
>> O_BINARY, too. See also for pattern in libiberty mkstemps.c
>>
>> Regards,
>> Kai
>>
>>
>>
>
> It looks like O_BINARY is already defined in system.h, so all it needs is
> the patches to open().
>
> I backed off my shot gun fix and there are just two places that appear to be
> problem:
>
> lto_elf_file_open () in lto-elf.c
> lto_read_section_data() in lto.c
>
> With O_BINARY on read/write remove failures from my simple test.

A patch that adds O_BINARY to those is ok if it passes bootstrap & testing
on a linux platform.

Thanks,
Richard.

> Andy
>
>

Reply via email to