On 10/30/2010 01:16 AM, Dave Korn wrote: >> Do we really want to keep re-reading section data for every section >> lookup we do? Can't we do this in objfile_open_read? > > It should only be necessary to do one section lookup per object file anyway. > Keep extra data hanging around in memory in the backend just so that we can > write algorithmically inefficient code in the client? Seems like a bad > tradeoff to me!
Uh, really? I thought there were like a half-dozen lto sections... > The line you quoted uses IMAGE_SCN_ALIGN_1BYTES. That's all we'll ever need > for LTO sections. Perhaps, but there's an argument to the create_section function that specifies the alignment. If we only need 1-byte alignment that's fine, but we should either assert that's true, omit the argument, or properly support it. r~
