On Mon, Nov 15, 2010 at 11:53:05AM -0800, Richard Henderson wrote:
> On 11/15/2010 11:12 AM, Jakub Jelinek wrote:
> > -     if (simple_cst_equal(TREE_VALUE (op), memory_identifier_string) == 1)
> > +     if (strcmp (TREE_STRING_POINTER (TREE_VALUE (link)), "memory") == 0)
> 
> I prefer this solution.  I think memory_identifier_string is over-engineering.
> Patch to remove it entirely is pre-approved.

Honza even committed this to the trunk in May, it is just release branches
that are broken (and only in 4.5 it matters a lot because it happens with
the default flags).

        Jakub

Reply via email to