On Fri, Jan 28, 2011 at 08:25, Joseph S. Myers <jos...@codesourcery.com> wrote:
> If a patch (over 400kB) is being excluded from the message because of size > (and somewhat larger patches could still be included as gzipped I have not looked into upload.py's source code, so I don't know if the limits are set in the uploader or the server. I know that the limits for the description message set by the uploader is ~10kB, but email replies sent to the issue do not seem to have limits (or they are <400kB). I replied to my own patch submission with the original patch, and the issue was updated without errors. > attachments, though very few patches approach 400kB anyway), it would be > good for the message to explicitly say so if possible; otherwise it looks > like an ENOPATCH mistake. Technically, Rietveld solves the ENOPATCH problem because the patch is *always* available at the URL produced in the patch message. The easiest way of addressing the lack of patch text in the submission is to reply to it with the original patch. But there may be some changes we can do to upload.py to make this more automatic. I'll take a look. Diego.
