On Thu, Nov 15, 2012 at 8:48 AM, Michael Matz <m...@suse.de> wrote: [...] > The method name should imply the action, e.g. 'add_stmt' or append_stmt > or the like.
strongly agreed. [...] > All in all I think we can severely improve on building gimple statements > without introduction of any helper class. Basically, whenever a helper > class merely contains one member of a different type, then I think that > other type should be improved so that the wrapper class isn't necessary > anymore. Fewer types -> good :) no, it is the opposite. Distinct abstractions should be materialized by distinct types. => less opportunities for bugs. -- Gaby
