On 10/28/2017 11:18 AM, Richard Biener wrote: > On October 28, 2017 9:28:38 AM GMT+02:00, Jeff Law <l...@redhat.com> wrote: >> >> Jan, >> >> What's the purpose behind calling vrp_meet and >> extract_range_from_unary_expr from within the IPA passes? >> >> AFAICT that is not safe to do. Various paths through those routines >> will access static objects within tree-vrp.c which may not be >> initialized when IPA runs (vrp_equiv_obstack, vr_value). >> >> While this seems to be working today, it's a failure waiting to happen. > > Those functions are fine to use IIRC. You have to look at how they interact with those global variables within tree-vrp.c They're complex enough that I can't convince myself they're actually safe. And even if they're safe today, the lack of encapsulation makes them ripe to be broken later by accident.
Jeff