On 7/28/18, Bruce Korb <bruce.k...@gmail.com> wrote: > ../../autoopts/makeshell.c: In function ‘text_to_var’: > ../../autoopts/makeshell.c:324:14: error: this statement may fall > through [-Werror=implicit-fallthrough=] > (*(opts->pUsageProc))(opts, EXIT_SUCCESS); > ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > This warning goes away if the comment "/* FALLTHROUGH */ is present. > You are missing a condition: > > switch (which) { > case TT_LONGUSAGE: > (*(opts->pUsageProc))(opts, EXIT_SUCCESS); > /* NOTREACHED */ > > Please add the exception for a "/* NOTREACHED */" comment. Thank you. >
I suggested gcc start recognizing "/*NOTREACHED*/" in bug 53479 comment 14 but got shot down there, too: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53479#c14