Jacob Bachmeyer wrote:
Maciej W. Rozycki wrote:
[...]
I ran a quick bisection and the culprit turned out to be:
ba60272a5ac6f6a7012acca03f596a6ed003f044 is the first bad commit
commit ba60272a5ac6f6a7012acca03f596a6ed003f044
Author: Jacob Bachmeyer <jcb62281+...@gmail.com>
Date: Mon May 25 08:40:46 2020 -0600
Establish a default C compiler by evaluating [find_gcc] if no
other compiler is given.
So this regression has to be fixed before any new release is made.
I will look into this. So far, I have confirmed that the problem does
occur and that setting the "compiler" board_info key in
baseboards/unix.exp seems to avoid it. It looks like the default is
not being selected in all cases where it should be used. I still need
to find the exact problem to write a regression test to isolate this
bug and make it stay squashed.
After further efforts, and a few hours wasted trying to figure out why
additional tracing code added to default_target_compile was not
producing output, I eventually decided to just make
default_target_compile throw a Tcl error -- and I did not get a Tcl
error when running the tests...
That is "very interesting" and a quick grep -R reveals the culprit: the
GDB testsuite is overriding default_target_compile in
gdb/testsuite/lib/future.exp. Comments indicate that that file was
intended to temporarily bundle certain features with the GDB testsuite
that had not yet been merged into upstream DejaGnu -- in 2004. Now
DejaGnu core is continuing to develop, leaving the old code copied into
the GDB testsuite broken, and making this NOTOURBUG.
In short, this is not a regression in DejaGnu; this is code duplicated
into the GDB testsuite that was slated for removal from that location
years ago and needs to be removed from the GDB testsuite, or at least
made conditional on running under a version of DejaGnu old enough to
require it, if such versions are still supported for running the GDB
testsuite. If that code has added features not present in upstream
DejaGnu over the years, now is the time to get those patches in.
-- Jacob
