On Mon, 22 Nov 2021 at 19:38, Martin Liška <mli...@suse.cz> wrote: > > On 11/22/21 16:22, Dmitry Vyukov wrote: > > I wanted to give heads up regarding a significant re-design of the > > ThreadSanitizer runtime: > > https://reviews.llvm.org/D112603 > > Currently it's submitted: > > https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027 > > And I noticed the following new warnings: > > libsanitizer/tsan/tsan_shadow.h:93:32: warning: enumerated and non-enumerated > type in conditional expression [-Wextra] > libsanitizer/tsan/tsan_shadow.h:94:44: warning: enumerated and non-enumerated > type in conditional expression [-Wextra] > > *typ = (part_.is_read_ ? kAccessRead : kAccessWrite) | > (part_.is_atomic_ ? kAccessAtomic : 0) | > (part_.access_ == kFreeAccess ? kAccessFree : 0); > > I think 0 should be replaced with kAccessWrite, am I right? Should I create a > pull request for it?
I've already reverted the change. So I will include a fix into the next version. Thanks for notifying.
