On Wed, Feb 8, 2023 at 10:44 AM Even Rouault <even.roua...@spatialys.com>
wrote:

> Michael,
>
> Feel free to submit a fix as there's obviously no justification for the
> discrepancy other than just being accidental.
>

Ah ok, mostly I was just confused why it's not an error for the compiler
... but I'm getting used to surprises learning C++ :)

PR incoming, thanks!

Cheers, Mike



> There are likely hundreds of similar occurrences in the code base.  I
> believe there's a compiler warning (or at least cppcheck) to detect this,
> but it is not activated.
>
> Even
> Le 08/02/2023 à 00:35, Michael Sumner a écrit :
>
> This is not causing any problems afaict, but I happened to notice the
> plural for 'padfExtents' in the gdal_alg.h signature for
> GDALSuggestedWarpOutput2 compared to gdaltransformer.cpp
>
>
> https://github.com/OSGeo/gdal/blob/579693c2975cda414af75239e09b8b7b952029ca/alg/gdal_alg.h#L264
>
>
> https://github.com/OSGeo/gdal/blob/579693c2975cda414af75239e09b8b7b952029ca/alg/gdaltransformer.cpp#L412
>
>
> The discrepancy is visible in the doc here:
>
>
> https://gdal.org/api/gdal_alg.html#_CPPv424GDALSuggestedWarpOutput212GDALDatasetH19GDALTransformerFuncPvPdPiPiPdi
>
> Cheers, Mike
>
>
>
> --
> Michael Sumner
> Software and Database Engineer
> Australian Antarctic Division
> Hobart, Australia
> e-mail: mdsum...@gmail.com
>
> _______________________________________________
> gdal-dev mailing 
> listgdal-dev@lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/gdal-dev
>
> -- http://www.spatialys.com
> My software is free, but my time generally not.
>
>

-- 
Michael Sumner
Software and Database Engineer
Australian Antarctic Division
Hobart, Australia
e-mail: mdsum...@gmail.com
_______________________________________________
gdal-dev mailing list
gdal-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/gdal-dev

Reply via email to