On 10/31/2011 09:44 AM, Nick Treleaven wrote:
On 31/10/2011 15:07, Nick Treleaven wrote:
On 31/10/2011 13:57, Matthew Brush wrote:
I'm not sure we would see a flood on a merge, probably only one
commit saying 'merged gtkbuilder branch'? The gtkbuilder commits
should appear as they are committed, not on merge.
I think when you merge it makes all the commits onto the branch that
was merged into also. At least this is what happened on the
xfce-commits list when one of the devs merged several branches with a
total of 800+ commits in them, each triggering a commit mail :)
Ok, but ideally it would do as I described, like the github commit list
for the scintilla-update merge:
https://github.com/geany/geany/commits
Anyway I think the problem of only showing the first commit of the push
in the subject makes the commit mails harmful because changes can easily
be missed. This problem seems more important than the potential flooding
issue. In practice our branch merges likely wouldn't have 800 commits.
+1
And if we do have a case where a massive amount of commits will happen
at once, we could just temporarily disable the commit mails or ask
Enrico to do it. IIRC it would just be a matter of turning of the
webhook through Github admin settings and turning it back on afterwards.
Cheers,
Matthew Brush
_______________________________________________
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
