jonnybot0 commented on code in PR #310: URL: https://github.com/apache/groovy-geb/pull/310#discussion_r2983745592
########## integration/geb-testcontainers/src/integration-test/groovy/geb/testcontainers/PortConfigFromClassSpec.groovy: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package geb.testcontainers + +import spock.lang.Narrative + +/** + * Test spec to verify that the correct port configuration is being used. + * Some reference taken from: + * groovy-geb/module/geb-core/src/test/groovy/geb/conf/ConfigurationLoaderSpec.groovy + */ +@Narrative("To verify that class field overrides config file.") +class PortConfigFromClassSpec extends ContainerGebSpec { + + static TestFileServer server + + int hostPort = 8000 Review Comment: This field seems effectively unused. That makes me wonder what exactly this test is testing. `"should use the class field value"` doesn't seem to describe what the test is doing. Likewise, this test has been flaky for me locally. At first I thought it was because I had other containers running on that port, but that was not it. I've pushed what I think is a fix to my review branch, but I'd like to know what the purpose of this test is. Just because it passes doesn't matter if I don't understand what functionality this test is meant to verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
