jonnybot0 commented on code in PR #310: URL: https://github.com/apache/groovy-geb/pull/310#discussion_r3024508396
########## Dockerfile: ########## Review Comment: So, I think that building this Dockerfile is a separate concern from testcontainers integration that got folded into this PR. Can we back that out and review it on its own, separately? We made a decision a while back to use the off-the-shelf Docker containers for most build concerns, rather than publishing our own just for CI. Unless I'm misreading the PR, we don't really need it, the docker-entrypoint.sh, build-in-docker.sh, and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
