Hi Carlos,

[snip]
>Did you notice that the images are not 800x600 when selecting 800x600?
>This is because the code only outputs the relevant schematic, without
>the blank border that libgdgeda being in the libgdgeda output.
>

        Yup.  I'm okay with this.

[snip]
>Thanks for the changes. I think that picture and PNG support are
>complete now.

        Agreed.

[snip]
>I would not use it this way. You can use GTK_MAJOR_VERSION and
>GTK_MINOR_VERSION which are defined by GTK. If you are using a widget
>available only from version 2.6, then you can write something like this:
>
>#if ((GTK_MAJOR_VERSION > 2) || \
>     ((GTK_MAJOR_VERSION == 2) && (GTK_MINOR_VERSION >= 6)) )
>  <code for GTK version 2.6>
>#endif

        Hmmm, yeah this is probably better.  I will remove my changes
from configure.ac once I try it out.  Thanks.

>
>In fact, I am using them in a file load/save window replacement (using
>the GTK file chooser), and they are working great.
>If you are curious, I have the new file chooser working, but I'm stuck
>again trying to get a preview of the file for the file chooser.... I

        Please check in the changes even without the previewer.  We can
worry about that later.  Please just make sure that the existing file
dialog box still works since I don't want to break support for gtk+
2.2.x just yet.

>think we really need some way to get a pixbuf from a toplevel structure
>_without_ defining or using a drawing_area (which needs to be visible)
>and totally unaware of windows or drawing_areas defined in w_current

        I think it should be quite doable to reuse the exising x_preview_*
code to generate the previewer, since the new file chooser has hooks for
a custom gtk+ widget.

        Thanks,

                -Ales

Reply via email to