Hi Carlos,
[snip]
>I checked in the changes. I have GTK 2.6 installed, and I don't have
>access to any machine with GTK 2.2, so I am not able to test the changes
>with GTK 2.2. When I did the changes, I was careful to keep the old
>code, so I hope there won't be big problems.
>I created a new x_fileselect_setup using defines to keep the old code,
>so if GTK 2.4 or better isn't available, or it is called to add a
>component, it calls the old function x_fileselect_setup_old.
Great. I looked at your changes and they look good (just a quick
look). I also see that you just checked in a fix to get the preview working
again on the component placement browser. :)
[snip]
>The preview infrastructure is mostly done. The code setting the preview
>widget is commented in x_fileselect_setup. The preview widget callback
>needs to be a new one (x_preview_update_gtk24) because the arguments
>changed. To get it working, we have to setup the preview toplevel
>structure and hack x_image_get_pixbuf so it can get a pixbuf from it.
>The rest is easy.
Actually I was looking at this particular code yesterday morning
and after some experimentation I got the preview widget working as is
(with no pixbuf creation involved). I will be checking in my changes
once I get them finalized. I'm quite thrilled that we can finally use
the supported gtk+ file browser.
-Ales
