Dne neděle 28 září 2008 Klaus Ethgen napsal(a):
> Hi there,
>
> as I told before I did several patches for gqview. Now I solve it to
> port them for geeqie too.
>
> It would be nice if they could be applied to upstream.

The patches looks good, thanks.

>
> To the patches (3 small and 1 big):
> 1. I simply enlarge the dupe window as 600px is to small for localized
>    text.
>
> 2. There are images with execute right. As I use git to track my changes
>    it can give that as patch too.
>
> 3. I add a additional check for a '[' in the comment section. Otherwise
>    it gets lost at all.

I committed these patches.

>
> 4. This is the biggest patch. It add real support for GPS data. As the
>    data format for ExifItem is changed I had to do alter the function
>    exif_item_get_rational to read multiple rational data (GPSLatitude
>    and GPSLongitude are 3 values.
>

This patch needs some improvements, mostly cosmetic:
- ifdef HAVE_EXIV2 should not be needed, the exif_get... functions should work 
for both implementations
- there are some compiler warnings
- indentations should be changed according to the CODING file

Thanks,

Vladimir

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to