-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am Mo den 29. Sep 2008 um 22:27 schrieb Vladimir Nadvornik: > The patches looks good, thanks.
Fine. > > 4. This is the biggest patch. It add real support for GPS data. As the > > data format for ExifItem is changed I had to do alter the function > > exif_item_get_rational to read multiple rational data (GPSLatitude > > and GPSLongitude are 3 values. > > > > This patch needs some improvements, mostly cosmetic: > - ifdef HAVE_EXIV2 should not be needed, the exif_get... functions should > work > for both implementations I did implement it first only with exif.c (gqview). Then I ported it to the new exiv2.cc code. I did not test if the exif_get... function also work with the old code. But feel free to modify it. > - there are some compiler warnings I will look for it. Thanks. > - indentations should be changed according to the CODING file Ah. :-) Yes, I didn't find a Vim string in the source so I used mine. ;-). What do you think about setting the correct indentation parameter for Vim in any file? That might be helpful and easy to do. Regards Klaus - -- Klaus Ethgen http://www.ethgen.de/ pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <[EMAIL PROTECTED]> Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQEVAwUBSOFo65+OKpjRpO3lAQII3Qf/YiYIj8eeHUteK6SRDALMB0CBbpGYoEcZ FMFzRGRRmCzRx31oUZgANdztXOSgpW5sEfmTxm/VHMaCLCqqkKzmje8Kfg7aMW3K heO+upATFHtEhHxHmsYoZbiZmdMrueLxg6RIthAtC69YighxBepwcQIKcIIqCmX7 ZOCseGQ38M6H0amuh4GenDZLNHwlUL2kOEqQMEMI9epTwFQRNoKB+BXPMz1nl6WS I4SNGILp/VTjmfnKMctPufRwGq5H4TZLk6+mwrhdSK5gGORruSd5+Ts1XX81kOQ9 rtjstcvdP8XhzVVs3j1D42GKZK9aIImxJbTKN1il7+R9z9hmMrp4TQ== =IEod -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
