> On 2011-06-21 04:49:06, Korey Sewell wrote: > > src/cpu/inorder/inorder_dyn_inst.cc, line 439 > > <http://reviews.m5sim.org/r/748/diff/3/?file=13063#file13063line439> > > > > separate patch. > > > > also, what code in locked_mem.hh requires this?
I have to use set/readMiscRegNoEffect instead of set/readMiscReg in the locked_mem.hh, to avoid a problem caused by link load instructions.(the tick becomes a large number and it says 'because simulate() limit reached'). But I haven't found the root cause, so I didn't commit a diff of locked_mem.hh. Could you tell me, does a separate patch mean, delete the diff of nmadd/NoEffect here, and write a now review request? - Deyuan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/748/#review1347 ----------------------------------------------------------- On 2011-06-21 02:16:53, Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/748/ > ----------------------------------------------------------- > > (Updated 2011-06-21 02:16:53) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Make the newly gem5 support mips branch likely instruction again. > Fix 4 files: > src/arch/mips/isa/formats/branch.isa > src/cpu/inorder/inorder_dyn_inst.cc > src/cpu/inorder/resources/branch_predictor.cc > src/cpu/inorder/resources/fetch_seq_unit.cc > > > Diffs > ----- > > src/arch/mips/isa/decoder.isa 00766f5b8177 > src/arch/mips/isa/formats/branch.isa 00766f5b8177 > src/cpu/inorder/inorder_dyn_inst.cc 00766f5b8177 > src/cpu/inorder/resources/branch_predictor.cc 00766f5b8177 > src/cpu/inorder/resources/fetch_seq_unit.cc 00766f5b8177 > > Diff: http://reviews.m5sim.org/r/748/diff > > > Testing > ------- > > Tested. > > > Thanks, > > Deyuan > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
