> On 2011-07-10 11:33:17, Ali Saidi wrote: > > src/cpu/o3/inst_queue_impl.hh, line 1096 > > <http://reviews.m5sim.org/r/767/diff/1/?file=13290#file13290line1096> > > > > Could you explain what is going on here? > > > > Previously these instructions did what? Sat here until the squash > > propagated? Is there a corner case of the translation currently being in > > progress and the instruction getting squashed and removed before this comes > > back? > > > >
Unfortunately no since it's been so long since I originally wrote this patch. I think what would happen is that squashed instructions would hang around here forever for whatever reason, and eventually O3 would get upset that there were too many instructions in flight. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/767/#review1401 ----------------------------------------------------------- On 2011-07-03 03:37:29, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/767/ > ----------------------------------------------------------- > > (Updated 2011-07-03 03:37:29) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Let squashed and deferred instructions issue. > > Let squahsed and deferred instructions issue so they don't accumulate and clog > up the CPU. > > > Diffs > ----- > > src/cpu/o3/inst_queue_impl.hh 1b4b9c05ad2b > > Diff: http://reviews.m5sim.org/r/767/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
