> On 2011-08-16 22:18:07, Brad Beckmann wrote: > > src/mem/ruby/network/garnet/BaseGarnetNetwork.py, line 39 > > <http://reviews.m5sim.org/r/776/diff/2/?file=14649#file14649line39> > > > > If the fault model only works with the fixed network, shouldn't these > > parameters be moved to the fixed network python class and not the base > > network class?
It's debatable if the fault model makes sense for the flexible network, so I wanted to leave that option open. If the user-defined pipeline is similar to the fixed network, then the fault model should be moderately accurate, while for major pipeline changes the fault model's vector may be way off. In any case, I would like to enable a user to call the fault model from the flexible network, consequently I defined fault_model as a module inside the base network to make that possible, if the user is willing to put some effort and adapt the model to its specific flexible network. > On 2011-08-16 22:18:07, Brad Beckmann wrote: > > src/mem/ruby/network/fault_model/FaultModel.cc, line 57 > > <http://reviews.m5sim.org/r/776/diff/2/?file=14644#file14644line57> > > > > Why 12? If this is a constant, please use a const int or define a > > macro. > > > > Also please add a space between math operators and operands: > > > > ex" "int i = 0;" took care of this: modified my spacing consistently with guidelines (throughout my files) and added an enum reference instead of 12 - Konstantinos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/776/#review1460 ----------------------------------------------------------- On 2011-08-17 16:12:19, Konstantinos Aisopos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/776/ > ----------------------------------------------------------- > > (Updated 2011-08-17 16:12:19) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan > Binkert, Brad Beckmann, and Tushar Krishna. > > > Summary > ------- > > GARNET: adding a fault model for resilient on-chip network research. > > This patch adds a fault model, which provides the probability of a number of > architectural faults in the interconnection network (e.g., data corruption, > misrouting). These probabilities can be used to realistically inject faults > in GARNET and faithfully evaluate the effectiveness of novel resilient NoC > architectures. > > > Diffs > ----- > > configs/ruby/Ruby.py 889818c58eff > src/mem/ruby/network/fault_model/FaultModel.hh PRE-CREATION > src/mem/ruby/network/fault_model/FaultModel.cc PRE-CREATION > src/mem/ruby/network/fault_model/FaultModel.py PRE-CREATION > src/mem/ruby/network/fault_model/SConscript PRE-CREATION > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 889818c58eff > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 889818c58eff > src/mem/ruby/network/garnet/BaseGarnetNetwork.py 889818c58eff > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 889818c58eff > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 889818c58eff > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh 889818c58eff > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 889818c58eff > > Diff: http://reviews.m5sim.org/r/776/diff > > > Testing > ------- > > > Thanks, > > Konstantinos > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
