----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/839/#review1493 -----------------------------------------------------------
src/arch/x86/tlb.cc <http://reviews.m5sim.org/r/839/#comment2016> Could a lot of this go into a doxygen comment for checkAndAllocNextPage()? - Ali On 2011-09-05 18:54:18, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/839/ > ----------------------------------------------------------- > > (Updated 2011-09-05 18:54:18) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Stack: Tidy up some comments, a warning, and make stack extension consistent. > > Do some minor cleanup of some recently added comments, a warning, and change > other instances of stack extension to be like what's now being done for x86. > > > Diffs > ----- > > src/arch/alpha/faults.cc b3585da1f970 > src/arch/sparc/faults.cc b3585da1f970 > src/arch/x86/tlb.cc b3585da1f970 > src/sim/process.cc b3585da1f970 > > Diff: http://reviews.m5sim.org/r/839/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
