----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/839/#review1511 -----------------------------------------------------------
Ship it! Other than the minor rephrasing of the comment, this looks great to me. src/sim/process.hh <http://reviews.m5sim.org/r/839/#comment2029> Minor nit: "if the fault should be fixed" is a little ambiguous (should be fixed already, or should be fixed by the caller)? How about: /// @return True if the fault has been fixed. - Steve On 2011-09-08 03:48:06, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/839/ > ----------------------------------------------------------- > > (Updated 2011-09-08 03:48:06) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Stack: Tidy up some comments, a warning, and make stack extension consistent. > > Do some minor cleanup of some recently added comments, a warning, and change > other instances of stack extension to be like what's now being done for x86. > > > Diffs > ----- > > src/arch/alpha/faults.cc b324639974f6 > src/arch/sparc/faults.cc b324639974f6 > src/arch/x86/tlb.cc b324639974f6 > src/mem/translating_port.cc b324639974f6 > src/sim/faults.cc b324639974f6 > src/sim/process.hh b324639974f6 > src/sim/process.cc b324639974f6 > > Diff: http://reviews.m5sim.org/r/839/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
