----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/845/ -----------------------------------------------------------
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary ------- event: minor cleanup Initialize flags via the Event constructor instead of calling setFlags() in the body of the derived class's constructor. I forget exactly why, but this made life easier when implementing multi-queue support. Also rename Event::getFlags() to isFlagSet() to better match common usage, and get rid of some unused Event methods. Diffs ----- src/cpu/o3/commit_impl.hh b3585da1f970 src/cpu/o3/inst_queue_impl.hh b3585da1f970 src/cpu/o3/lsq_unit_impl.hh b3585da1f970 src/dev/etherlink.cc b3585da1f970 src/mem/ruby/eventqueue/RubyEventQueueNode.hh b3585da1f970 src/sim/debug.cc b3585da1f970 src/sim/eventq.hh b3585da1f970 src/sim/sim_events.cc b3585da1f970 src/sim/stat_control.cc b3585da1f970 Diff: http://reviews.m5sim.org/r/845/diff Testing ------- Thanks, Steve _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
