----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1150/#review2558 -----------------------------------------------------------
Ship it! Seems to me this is just adding command-line access to override more fields of the SysConfig object. Andreas is right that it's not a fully general solution, but limitation really lies with the way SysConfig works and not with Jayneel's patch. This seems like a reasonable step until/unless someone rewrites the SysConfig stuff to be more general. - Steve Reinhardt On April 16, 2012, 11:53 a.m., Jayneel Gandhi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1150/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 11:53 a.m.) > > > Review request for Default. > > > Description > ------- > > Added the options to Options.py for FS mode with backward compatibility. It > is good to provide an option to specify the disk image and the memory size > from command line since a lot of disk images are created to support different > benchmark suites as well as per user needs. Change in program also leads to > change in memory requirements. These options provide the interface to provide > both disk image and memory size from the command line and gives more > flexibility. > > > Diffs > ----- > > configs/common/Options.py a6830d615effc2e644fd3ebd2553c569c1d4607f > configs/example/fs.py a6830d615effc2e644fd3ebd2553c569c1d4607f > configs/example/ruby_fs.py a6830d615effc2e644fd3ebd2553c569c1d4607f > > Diff: http://reviews.gem5.org/r/1150/diff/ > > > Testing > ------- > > Testing done to confirm backward compatibility > > > Thanks, > > Jayneel Gandhi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
