On 04/22/2012 10:30 PM, Nilay Vaish wrote:
On Sat, 21 Apr 2012, Andreas Hansson wrote:
I am not talking about the committ message, but rather my initial
review stating that the message associated with the mem_size
parameter is copy pasted from the disk image and not changed. I think
it would make sense to have an accurate help message for the
parameter, and thus would like to see it changed. Makes sense? I
remarked upon this in my very first set of comments.
With respect to the multiple memories (or lack there of), I am merely
requesting a comment line above the parameter stating that this
assumes a single memory in e system and that for multiple memories
the script itself has to be changed. I hope that also makes sense.
- Andreas
Andreas, your request is reasonable.
Jayneel, can you make the changes that Andreas has mentioned in his
comment?
Thanks
Nilay
Done. Review the changes. Thanks Andreas for bringing up the issues again.
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
