----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1153/#review2603 -----------------------------------------------------------
src/arch/isa_parser.py <http://reviews.gem5.org/r/1153/#comment2993> To be consistent, the source and destination registers should be be treated this way. src/cpu/static_inst.hh <http://reviews.gem5.org/r/1153/#comment2992> Instead of making a map, just put all the indexes here directly. It'll take the same amount of space and save a level of indirection. - Gabe Black On April 24, 2012, 2:13 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1153/ > ----------------------------------------------------------- > > (Updated April 24, 2012, 2:13 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8966:c8c03cb78aa1 > --------------------------- > ISA Parser: Decide source register indices at runtime > Currently the register indices for source and destination registers are > decided > statically by the isa parser. This patch moves this decision to run time. This > will be useful when register will be read based on a condition specified while > construction of a microop. > > > Diffs > ----- > > src/arch/isa_parser.py 91a6f8f07074 > src/cpu/static_inst.hh 91a6f8f07074 > > Diff: http://reviews.gem5.org/r/1153/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
